Export dialog tabs #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doerge
approved these changes
Apr 30, 2021
| @@ -4,7 +4,7 @@ namespace glTF_BinExporter | |||
| { | |||
| public static class Constants | |||
| { | |||
| public static ObjectType[] ValidObjectTypes = new ObjectType[] { | |||
| public static readonly ObjectType[] ValidObjectTypes = new ObjectType[] { | |||
| @@ -90,26 +94,26 @@ public Gltf ConvertToGltf() | |||
|
|
|||
| var sanitized = GlTFUtils.SanitizeRhinoObjects(objects); | |||
|
|
|||
| foreach(Tuple<Rhino.Geometry.Mesh[], Rhino.DocObjects.Material, Guid, RhinoObject> tuple in sanitized) | |||
| foreach(ObjectExportData exportData in sanitized) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #44
Resolves #45
Resolves #49
Resolves #28
Hopefully I didn't bundle too much in this one PR. I save the settings through the plugin settings. I had to tweak the export settings to make a bit more sense. Since the binary flag is inferred from extension, I moved it out of the settings to its own parameter that's passed in. This way the export settings are purely about the data conversion. The export materials and display color options weren't a huge change, but should be verified. Most of the options for exporting the meshes #46, #47, and #48 require #29 as a prerequisite which I'll get to working next.